MC-4544Firework light flash rendered too dark
What I expected to happen was:
Firework light flash texture being bright - because it's a LIGHT flash. Same goes for the colored firework particles.
What really happend was:
The light flash is actually dark (during nighttime practically not visible, during daytime it looks really odd). The colored particles should also appear bright (less visible during daytime, "glowing" bright appearance during nighttime).
Reproduction command provided by [Mod] Avoma here
Linked Issues
![[Mod] Avoma](../../../data/avatars/users/86198.png){kind=small}
- Unresolved
_zombiehunter- 30
- 9
- Confirmed
Normal- Platform
- Particles Rendering
- rendering resource-pack-support
12w50a - 1.21.4
12w50a 12w50b 1.4.6 1.4.7 1.5 13w11a 1.5.1 13w16a 13w16b 1.5.2 13w17a 13w18a 13w18b 13w18c 13w19a 13w21a 13w21b 13w22a 13w23a 13w23b 13w24a 13w24b 13w25a 13w25b 13w25c 13w26a 1.6 1.6.1 1.6.2 1.6.3 1.6.4 13w36a 13w36b 13w37a 13w37b 13w38a 13w38b 13w38c 13w39a 13w39b 13w41a 13w41b 13w42a 13w42b 13w43a 1.7 1.7.1 1.7.2 13w47a 13w47b 13w47c 13w47d 13w47e 13w48a 13w48b 13w49a 1.7.3 1.7.4 14w02a 14w02b 14w02c 14w03b 14w04a 14w04b 14w05a 14w05b 14w06a 14w06b 14w07a 1.7.5 14w11b 1.7.9 14w17a 1.8 1.8.1-pre3 1.8.7 1.10.2 16w38a 1.12.2 18w03b 18w05a 18w06a 1.13-pre1 19w06a 19w07a 19w08a 19w08b 19w09a 19w11a 19w11b 19w12b 19w13a 19w13b 19w14a 19w14b 1.14-pre2 1.14-pre3 1.14 1.14.1 1.14.2-pre1 1.14.2-pre2 1.14.2-pre3 1.14.2-pre4 1.14.2 1.14.3-pre1 1.14.3-pre2 1.14.3-pre3 1.14.3-pre4 1.14.3 1.14.4-pre3 1.14.4-pre4 1.14.4-pre5 1.14.4-pre6 1.14.4-pre7 1.14.4 19w34a 19w35a 19w36a 19w37a 19w38b 19w38a 19w39a 19w40a 19w41a 19w42a 19w44a 19w45a 19w45b 19w46a 19w46b 1.15-pre1 1.15-pre2 1.15-pre3 1.15-pre4 1.15-pre5 1.15-pre6 1.15-pre7 1.15 1.15.1 1.15.1-pre1 1.15.2-pre1 1.15.2-pre2 1.15.2 20w06a 20w07a 20w22a 1.16-pre5 1.16-pre6 1.16-pre7 1.16-pre8 1.16-rc1 1.16 1.16.3 1.16.4 20w48a 20w49a 20w51a 21w03a 1.16.5 21w05b 21w06a 21w07a 21w11a 21w15a 21w17a 1.17-rc1 1.17 1.17.1 1.18-pre6 1.18-pre8 1.18 1.18.1 1.18.2 1.19 1.19.2 1.19.3 1.19.4 23w14a 1.20-rc1 1.20 1.20.1 1.20.2 1.20.4 1.21.1 24w45a 1.21.4
Created Issue:
Firework light flash not visible at night
The firework light flash texture turns black during nighttime, therefore not visible.
Attachments1
The firework light flash texture turns
black during nighttime, therefore not visible.The firework light flash texture turns very dark during nighttime, therefore practically not visible.
Firework light flashnot visible at nightFirework light flash rendered too dark
The firework light flash texture turns very dark during nighttime, therefore practically not visible.
What I expected to happen was:
Firework light flash texture being bright - because it's a LIGHT flash. Same goes for the colored firework particles.What really happend was:
The light flash is actually dark (during nighttime practically not visible, during daytime it looks really odd). The colored particles should also appear bright (less visible during daytime, "glowing" bright appearance during nighttime).
Is this still a concern in the current Minecraft version? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases.
Is this still a concern in the current Minecraft version 14w11b / Launcher version 1.3.11 or later? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases.
![[Bot] Arisa](../../../data/assets/gravatar/mustek2.png){kind=small}
![[Mod] Neko](../../../data/avatars/users/92901.png){kind=small}
is blocked by
![[Mojang] Nathan Adams](../../../data/assets/gravatar/dinnerbone.png){kind=small}
![[Mod] CubeTheThird](../../../data/assets/gravatar/cubethethird.jpeg){kind=small}
Confirmed for 20w07a
![[Mod] violine1101](../../../data/avatars/users/92858.png){kind=small}
![[Mod] LateLag](../../../data/avatars/users/92884.png){kind=small}
is blocked by
![[Helper] Jack McKalling](../../../data/avatars/users/92859.png){kind=small}
![[Mojang] Adrian Östergård](../../../data/assets/gravatar/nighter.jpeg){kind=small}
![[Mod] SPGoding](../../../data/avatars/users/44622.png){kind=small}
![[Mod] Michael Wobst](../../../data/avatars/users/37868.png){kind=small}
![[Helper] Johnibur](../../../data/avatars/users/28381.png){kind=small}
![[Mod] tryashtar](../../../data/avatars/users/41963.png){kind=small}
is duplicated by
What I expected to happen was:
Firework light flash texture being bright - because it's a LIGHT flash. Same goes for the colored firework particles.What really happend was:
The light flash is actually dark (during nighttime practically not visible, during daytime it looks really odd). The colored particles should also appear bright (less visible during daytime, "glowing" bright appearance during nighttime).Reproduction command provided by [Mod] Avoma here
![[Mod] ampolive](../../../data/avatars/users/18949.svg){kind=small}
![[Mod] markderickson](../../../data/avatars/users/18946.svg){kind=small}
![[Mojang] slicedlime](../../../data/assets/gravatar/slicedlime.jpeg){kind=small}
![[Mod] turbo](../../../data/avatars/users/92867.png){kind=small}
The bug
While testing for MC-4544, I noticed the light flash isn't displayed at all now. Not sure about this, but it probably is not an intended change (at least it is not mentioned in the 1.13-pre2 changelog).
From Bob Morane:
Fireworks use the index span between 72 and 191 for the big flash of the explosion, but that area is empty in the particles.png file (red square in the attachment). It was probably supposed to use the sprite bordered in orange (which would be the 36-87 square).
Fireworks also use one too many sprite in their trail/spark animation and they go down to index 159. You can't notice it at first because the index is empty in the original texture. But if you fix the first error (by painting an explosion flash in the red square), you notice that the last sprite of the trail samples from that same flash square! (blue square). One error hiding the other 
.
This appears to be a duplicate of MC-4544. If you feel that this issue is affecting you, feel free to vote for the duplicated ticket, to give Mojang a basic idea of how many people are impacted by the problem. Just to further inform you, this will not determine how quickly the bug gets handled or fixed. Like I said earlier, it just gives the team a general understanding.
woops, really forgot about this. Yep, firework light flash didn't change in 1.5 and 13w11a, still looking weird. Best would be if Mojang changes the firework particle rendering (including the light flash particle texture!) completely to give them a brigher appeareance, similar as used in MCPatchers Custom Colors mod (giving them a more "glowing" appearance, as if they would give off light >>> by far more realistic !).
Updated the tickets title, description and added new screenshots to compare current and expected behavior.
Can you take more "expected" images during night? Are you proposing that at night the colors aren't washed out? Because the daytime image looks ugly.
It would be cool if the particles were blended in a way that you could see them better on a dark background, or better yet, actually had a "luminosity" factor that made them display differently in high and low light level environments. Not just day/night, but if you used one in a cave, it would create a flash of light (just a rendering thing though).
@insomniac_lemon:
The pale colors at night-time are simply hard-coded color values (they can be easily changed using MCPatchers Custom Colors mod to show more intense colors). Mojang could change the values too, I don't know why they prefer fireworks having such pale colors. This issue ticket refers mainly to the ugly appearance of firework particles during daytime (a light flash being dark => wrong rendering method), making the particles more colorful to better blend with dark backgrounds isn't directly related to this, so I drop the night-time images here:
Current appearance (pale particles):
http://i.imgur.com/QpJzSdv.jpg
Expected appearance (changed color value to RGB #FF0000):
http://i.imgur.com/nl6IvfR.jpg
To fix the ugly and dark appearance during daytime, the firework particles and light flash color values should simply be added to the sky color value:
black=000000, red: FF0000 --> 000000+FF0000=FF0000 --> normal red during nighttime, but particles much brighter during daytime because the sky is light blue --> much more realistic appearance! MCPatcher is doing it that way, it works fine and looks great.
Is this still a concern in the current Minecraft version 14w21b / Launcher version 1.4.4 or later? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases.
you mean 27b
Awaiting response ... hmm ... let's see ...
Nope - firework rendering hasn't changed up to 1.8.1-pre1, still getting a dark light flash
Is this still a concern in the current Minecraft version? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases. If this has been done, we can reopen the issue.
Keep in mind that the "Resolved"-Status on this ticket just means "Answered", and that we are waiting for further information on whether this issue still exists or not. It will be reopened as soon as the requested information has been delivered.
Yes, still a problem in recent MC versions up to 16w38a ...
Weird, I cannot reproduce this issue for 1.13.1.
Kraif, that might be because the light flash isn't rendered at all right now, see
MC-131356.Fixing this should theoretically be much easier now that particles.png has been split into separate files.
Please do not mark unreleased versions as affected.
You don't have access to them yet.
Can confirm in 20w48a.
Can confirm in 20w49a.
Can confirm in 20w51a.
Can confirm in 21w03a.
Can confirm in 21w05b.
Can confirm in 21w06a.
Can confirm in 21w07a. Video attached.
Can confirm in 1.16.5 and 21w11a.
Can confirm in 21w15a. You can use the following command to reproduce this issue:
/give @s firework_rocket{Fireworks:{Flight:1,Explosions:[{Type:1,Flicker:1,Trail:1,Colors:[I;12801229],FadeColors:[I;11743532]}]}}Can confirm in 21w17a.
Can confirm in 1.17.1.
Can confirm in 1.18.1.
Can confirm in 1.18.2.
Can confirm in 1.19.
Can confirm in 1.19.2.
This still occurs in 1.21.4. They're affected by lighting, if you put fireworks down two tubes of tinted glass, you'll see that one in a tube that is lit on the inside displays brighter that an unlit tube, even on the outside of the tube where the lighting is the same. This is odd for a light flash, that you'd not expect to act like fog.